Move reader_parser to arrow-cast (#3022) #3043
Conversation
| parser_primitive!(Time32SecondType); | ||
|
|
||
| /// Number of days between 0001-01-01 and 1970-01-01 | ||
| const EPOCH_DAYS_FROM_CE: i32 = 719_163; |
There was a problem hiding this comment.
Eventually it would be nice to move this into some sort of arrow-common so we had all the date/time constants in the same place (I feel like they are scattered around now)
There was a problem hiding this comment.
I think arrow_array::temporal_conversions has most of them now. In general I hope we can avoid an arrow-common, util libraries have a tendency to become generic dumping grounds without clear focus 😅
|
Benchmark runs are scheduled for baseline = 951caed and contender = b7bc79b. b7bc79b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Part of #'3022
Rationale for this change
Precursor to splitting out arrow-csv and arrow-json
What changes are included in this PR?
Are there any user-facing changes?
No